ci: setup GitHub actions #4514
Merged
ci: setup GitHub actions #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.
|
timdeschryver
force-pushed
the
ci/github-ci-affected
branch
2 times, most recently
from
b7d45cd
to
0b03e19
Compare
timdeschryver
force-pushed
the
ci/github-ci-affected
branch
2 times, most recently
from
be7eea2
to
8b42646
Compare
timdeschryver
force-pushed
the
ci/github-ci-affected
branch
from
98e32c8
to
d7611ce
Compare
timdeschryver
commented
Sep 6, 2024
| @@ -0,0 +1,109 @@ | |||
| name: main | |||
There was a problem hiding this comment.
I enabled this pipeline on PRs to test it out and then disabled it once the build was successful, here's one that's successful :
| @@ -25,14 +25,8 @@ module.exports = function (config) { | |||
| colors: true, | |||
| logLevel: config.LOG_INFO, | |||
| autoWatch: true, | |||
| browsers: ['CustomChrome'], | |||
| browsers: ['ChromeHeadless'], | |||
There was a problem hiding this comment.
Required, otherwise the CI needs to install chromium (which we did in CircleCI via an orb)
brandonroberts
approved these changes
Sep 6, 2024
|
Thanks Tim! |
Yea, it's my intention to keep them in parallel for a while. After v19 we can fully migrate and include the release step. |
rainerhahnekamp
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
First step of #4507
What is the new behavior?
Does this PR introduce a breaking change?
Other information
First step to make sure everything is set up properly :)
This will run CircleCI and GitHub Actions side by side.
Some stats:
Circle CI affect build (PR) 12m 28s - https://app.circleci.com/pipelines/github/ngrx/platform/3713/workflows/55e21343-4028-4ae5-8df5-34c3b6ab4ce0
GitHub affected build (PR) 16m 18s - https://github.com/ngrx/platform/actions/runs/10742124526
GitHub affected build (PR) 7m 43s - https://github.com/ngrx/platform/actions/runs/10743257281
CircleCI full build (main) 12m 28s - https://app.circleci.com/pipelines/github/ngrx/platform/3696/workflows/8cce591c-5094-4f1b-97c9-67444c675823
GitHub full build (main) 18m 0s - https://github.com/ngrx/platform/actions/runs/10742124522