Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to dockerfile entrypoint #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shizacat
Copy link

No description provided.

@vl-homutov
Copy link
Contributor

Please provide some explanation on why is this needed and/or what benefits it brings,
and update commit logs if you want this to be merged.

@shizacat
Copy link
Author

shizacat commented Feb 4, 2019

It will be easier to run the script. You will not need to know the name of interpreter (python) and full path to the script in to container. It will be sufficient to specify the arguments for the script, such as --port.
Example:

docker run --rm -ti nginx-ldap-auth --help

@mingalevme
Copy link

@vl-homutov, can you merge the PR, please? it's really not good rewrite the full command just to add some arguments. In my case I use args -u, -b, -D and -w of the nginx-ldap-auth-daemon.py-script.

Without PR I must rewrite the full CMD, i.e.

docker run nginx-ldap-auth python /usr/src/app/nginx-ldap-auth-daemon.py --host "0.0.0.0" --port "8888" -u "..." -b "..." -D "..."  -w "..."

So in case you change the interpreter and/or path to script the command above will be broke.

With PR is only:

docker run nginx-ldap-auth --host "0.0.0.0" --port "8888" -u "..." -b "..." -D "..."  -w "..."

And the command is works in case of changing interpreter and/or path to script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants