Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Create bower.json #39

Merged
merged 2 commits into from Apr 4, 2016
Merged

Create bower.json #39

merged 2 commits into from Apr 4, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2016

For use with Bower.io, ie. via http://rails-assets.org/ which would eliminate the need of repos such as https://github.com/ecleel/jquery-oembed-rails.

For use with Bower, ie. via http://rails-assets.org/ which would eliminate the need of repos such as https://github.com/ecleel/jquery-oembed-rails.
@potench
Copy link

potench commented Apr 4, 2016

Thanks for the PR @hakkiplaten. Sign the CLA above and we'll get this landed.

@ghost
Copy link
Author

ghost commented Apr 4, 2016

All done. Thanks!

"license": "MIT",
"ignore": [
"**/.*",
"node_modules",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a couple Updates

  • jquery should be included as a dependency
  • node_modules, bower_components and test(s) don't need to be ignored cause they don't exist in this module. You should instead ignore examples/, *.md, and CHANGELOG.

@ghost
Copy link
Author

ghost commented Apr 4, 2016

Good catch! Changes committed. jQuery should already be included as a dependency, however I'm not sure about the version number.

@potench potench merged commit 88ebba0 into nfl:master Apr 4, 2016
@ghost
Copy link
Author

ghost commented Apr 4, 2016

Had an invalid version number. Should be fixed now.

@ghost
Copy link
Author

ghost commented Apr 7, 2016

Could we merge #41? Bower should automatically pick up on it and add it to its available versions, which in turn should fix jquery-oembed-all has no versions defined. Please create an issue in component's repository. at https://rails-assets.org/components/new.

Thank you!

@ghost
Copy link
Author

ghost commented Apr 8, 2016

Turns out this field is now ignored by Bower:

https://github.com/bower/spec/blob/master/json.md#version

Courtesy of @hut8:

tenex/rails-assets#82

@potench hence, would you mind merging the latest and renaming the git tag to a semver one instead (ie. 0.9.0-rc1)?

Ref. https://github.com/npm/node-semver#range-grammar

@potench
Copy link

potench commented Apr 8, 2016

@hakkiplaten let's remove the bower config. Not sure why anyone would use bower over npm at this point anyways.

@ghost
Copy link
Author

ghost commented Apr 8, 2016

@potench this is discussed at length at tenex/rails-assets#291, but the common consensus seems to be that Bower and the Bower proxy Rails-Assets.org is currently the simplest way for Ruby on Rails developers to maintain their JS dependencies.

JS front-end development is moving too fast, and current NPM solutions for Ruby on Rails are too complex.

@hut8
Copy link

hut8 commented Apr 8, 2016

@hakkiplaten you can also fork this repository and push a tag if you want to make sure the steps are exactly right. Maintaining the bower.json file in this repo shouldn't be a big issue considering that the version doesn't need to be bumped.

@ghost
Copy link
Author

ghost commented Apr 10, 2016

@hakkiplaten you can also fork this repository and push a tag if you want to make sure the steps are exactly right.

@hut8 that would have to be as a last resort.

Maintaining the bower.json file in this repo shouldn't be a big issue considering that the version doesn't need to be bumped.

Good point!

@ghost
Copy link
Author

ghost commented Apr 11, 2016

@potench mind taking a last stab at this?

  1. Merge Remove bower.json version field as it's ignored by Bower #42
  2. Rename this repo's version tag from 0.9RC1 to the standard semantic version format (http://semver.org/) 0.9.0-rc1 (Make git version tag semantic #43) to satisfy both NPM and Bower

This way, Rails developers can use this repo directly and no longer have to be dependent on wrappers such as https://github.com/ecleel/jquery-oembed-rails whose last commit is from 2014.

@joshjordan
Copy link

@potench any word here, friend? Over at https://github.com/tenex/rails-assets we're trying to push semantic version tags to help other tools (like Bower, which rails-assets uses) integrate with libraries like this one.

I bet @hakkiplaten would help you out if you need it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants