Release PR for 2.2.2 Patch Release #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove glob from process definition when using ECR container
Remove public_aws_ecr profile
in the configuration files and docs. Signed-off-by: Rob Syme <[email protected]>
Co-authored-by: Gregor Sturm <[email protected]>
Co-authored-by: Christopher Mohr <[email protected]>
Attempt at introducing meta2 everywhere
Update Mirbase URLs structure to match their new structure
Merge-template-2.9 & mirbase fixes
apeltzer
requested review from
robsyme,
maxulysse,
christopher-mohr and
grst
|
jfy133
reviewed
Sep 1, 2023
CHANGELOG.md
Outdated
| @@ -3,7 +3,16 @@ | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [v2.2.1](https://github.com/nf-core/smrnaseq/releases/tag/2.2.1) - 2023-05-08 | |||
| ## dev | |||
There was a problem hiding this comment.
Jumping ahead if this is a patch release?
There was a problem hiding this comment.
Missing version bumps for multiQC and fasto for example
There was a problem hiding this comment.
Missing updates to paths for one of the tools (and removing .gz)
christopher-mohr
requested changes
Sep 4, 2023
grst
approved these changes
Sep 4, 2023
maxulysse
reviewed
Sep 4, 2023
Co-authored-by: Christopher Mohr <[email protected]>
Co-authored-by: Christopher Mohr <[email protected]>
Adjust bits from PR review
apeltzer
commented
Sep 4, 2023
Bugfix for users who are running offline / with -all distribution as seen in discussion with @bentsherman nextflow-io/nextflow#4126
christopher-mohr
approved these changes
Sep 5, 2023
subworkflows/local/genome_quant.nf
Outdated
| include { BOWTIE_MAP_SEQ as BOWTIE_MAP_GENOME } from '../../modules/local/bowtie_map_mirna' | ||
|
|
||
| workflow GENOME_QUANT { | ||
| take: | ||
| fasta | ||
| fasta |
There was a problem hiding this comment.
Not sure if the identation is wrong here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).