Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge-template-2.9 & mirbase fixes #272

Merged
merged 19 commits into from
Sep 1, 2023
Merged

Merge-template-2.9 & mirbase fixes #272

merged 19 commits into from
Sep 1, 2023

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 9c09116

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-01 11:36:44

@apeltzer apeltzer added this to the 2.2.1 milestone Aug 30, 2023
@apeltzer apeltzer mentioned this pull request Aug 30, 2023
Closed
grst
grst requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of minor things

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@apeltzer apeltzer requested a review from grst August 30, 2023 07:51
grst
grst approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

christopher-mohr
christopher-mohr reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As just discussed LGTM, we just need to adapt to the new samtools subworkflows.

@apeltzer apeltzer changed the title Merge-template-2.9 Merge-template-2.9 & mirbase fixes Sep 1, 2023
christopher-mohr
christopher-mohr approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, apart from that LGTM!

workflows/smrnaseq.nf Show resolved Hide resolved
@apeltzer apeltzer merged commit 2b4253f into dev Sep 1, 2023
8 checks passed
@apeltzer apeltzer deleted the merge-template-2.9 branch September 1, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-mohr christopher-mohr christopher-mohr approved these changes

@grst grst grst approved these changes

Assignees
No one assigned
Labels
PR Open
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@apeltzer @christopher-mohr @grst @robsyme