Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc related to simpleaf, alevin-fry and salmon. #368

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Update doc related to simpleaf, alevin-fry and salmon. #368

merged 5 commits into from
Sep 24, 2024

Conversation

an-altosian
Copy link

In #361, I promised that I would update the doc related to simpleaf, alevin-fry and salmon. Here you go. ;)

Best,
Dongze

@an-altosian an-altosian changed the title Dev Update doc related to simpleaf, alevin-fry and salmon. Sep 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 973508b

+| ✅ 204 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-16 03:37:34

@DongzeHE DongzeHE requested review from fmalmeida, heylf and grst and removed request for fmalmeida and heylf September 22, 2024 22:56
fmalmeida
fmalmeida approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@fmalmeida fmalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks neat, I have only one genuine question. Othewise, it LGTM.

CITATIONS.md
* [Alevin-fry](https://doi.org/10.1038/s41592-022-01408-3)

> He, D., Zakeri, M., Sarkar, H. et al. Alevin-fry unlocks rapid, accurate and memory-frugal quantification of single-cell RNA-seq data. Nat Methods 19, 316–322 (2022).

* [Alevin](https://doi.org/10.1186/s13059-019-1670-y)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is alevin still relevant here? Is alevin-fry totally different or it uses alevin?

Copy link
Author

@an-altosian an-altosian Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, alevin is definitely relevant here. As the module in salmon for single-cell data quantification, it is the predecessor of alevin-fry and the work where alevin-fry is build upon. So, although the alevin-fry workflow does not directly call the salmon alevin module for read quantification, I would suggest to keep the citation here ;). Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@DongzeHE DongzeHE merged commit 3e2412d into nf-core:dev Sep 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalmeida fmalmeida fmalmeida approved these changes

@grst grst Awaiting requested review from grst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@an-altosian @fmalmeida @DongzeHE