Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modules #270

Closed
wants to merge 2 commits into from
Closed

Update modules #270

wants to merge 2 commits into from

Conversation

grst
Copy link
Member

@grst grst commented Sep 27, 2023 •
edited
Loading

Update modules before patch release

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

This comment was marked as outdated.

Sign in to view
@grst grst changed the base branch from master to dev September 27, 2023 08:15
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@grst grst requested a review from apeltzer September 27, 2023 08:16
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 5a93ca2

+| ✅ 151 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌   5 tests failed       |-

❌ Test failures:

  • files_unchanged - CODE_OF_CONDUCT.md does not match the template
  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - lib/NfcoreTemplate.groovy does not match the template
  • multiqc_config - 'assets/multiqc_config.yml' does not contain a matching 'report_comment'.

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-27 08:17:36

@grst grst closed this Sep 27, 2023
@grst
Copy link
Member Author

grst commented Sep 27, 2023

Will be part of template update #269

@grst grst deleted the grst-update-modules branch March 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer Awaiting requested review from apeltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grst