Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiQC dupRadar custom plot: specify plot_type explicitly #1137

Merged
merged 4 commits into from
Dec 11, 2023
Merged

MultiQC dupRadar custom plot: specify plot_type explicitly #1137

merged 4 commits into from
Dec 11, 2023

Conversation

vladsavelyev
Copy link
Contributor

@vladsavelyev vladsavelyev commented Dec 4, 2023 •
edited
Loading

Fixes MultiQC/MultiQC#2200

When plot_type is not specified, MultiQC tries to predict an intended plot type. Sometimes it turns out to be tricky. Due to a bug fix in 1.16 to handle numeric sample names in custom contents bar plots, MultiQC started to interpret this dupRadar line plot data as a bar plot.

The easiest fix would be to specify plot_type explicitly, this this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @vladsavelyev,

It looks like this pull-request is has been made against the vladsavelyev/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the vladsavelyev/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@vladsavelyev vladsavelyev mentioned this pull request Dec 4, 2023
Closed
4 tasks
@vladsavelyev vladsavelyev changed the base branch from master to dev December 4, 2023 16:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dc2d75e

+| ✅ 144 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 3.13.2
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnaseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-05 14:00:54

ewels
ewels approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ewels ewels merged commit e4c8d67 into nf-core:dev Dec 11, 2023
29 of 30 checks passed
@vladsavelyev vladsavelyev deleted the multiqc-dupradar-plottype branch December 13, 2023 11:12
@drpatelh drpatelh added this to the 3.13.3 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

Custom content: Bar graph detected instead of line graph
4 participants
@vladsavelyev @ewels @drpatelh @pinin4fjords