Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable conda #120

Merged
merged 2 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/local/plot_score_distribution.nf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ process PLOT_SCORE_DISTRIBUTION {
label 'cache_lenient'
label 'process_medium_memory'

conda "bioconda::bioconductor-alphabeta:1.8.0"
conda "bioconda::bioconductor-alphabeta=1.8.0"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/bioconductor-alphabeta:1.8.0--r41hdfd78af_0' :
'biocontainers/bioconductor-alphabeta:1.8.0--r41hdfd78af_0' }"
Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ profiles {
podman.enabled = false
shifter.enabled = false
charliecloud.enabled = false
channels = ['conda-forge', 'bioconda', 'defaults']
Copy link
Member

@skrakau skrakau May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this needed to be changed? It seemed at other locations it's still used as before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a silent bug since dec 2022! I already posted this on slack: https://nfcore.slack.com/archives/CE5LG7WMB/p1714721754644179

Without the conda. it is not considered for the creation of the environment! This is probably also an issue in nf-core/epitopeprediction! @jonasscheid

conda.channels = ['conda-forge', 'bioconda', 'defaults']
apptainer.enabled = false
}
mamba {
Expand Down
4 changes: 0 additions & 4 deletions subworkflows/local/utils_nfcore_metapep_pipeline/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ workflow PIPELINE_COMPLETION {
// Check and validate pipeline parameters
//
def validateInputParameters() {
// Exit if running this pipeline with -profile conda / -profile mamba
if (workflow.profile.tokenize(',').intersect(['conda', 'mamba']).size() >= 1) {
error "This pipeline does not support Conda. Please use a container engine such as Docker or Singularity instead."
}
// Exit if peptide length parameters are exchanged
if (params.min_pep_len > params.max_pep_len) {
error "The minimum peptide length needs to be smaller or equal than the maximum. See 'https://nf-co.re/metapep/dev/parameters' for more information."
Expand Down
Loading