Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epytope switch in process peptide_prediction #148

Merged

Conversation

jonasscheid
Copy link
Contributor

@jonasscheid jonasscheid commented Mar 17, 2022

The new release of epytope (v3.0.0) provides an altered prediction structure due to the incorporation of rank metrics.
This PR aims to embed the new prediction structure in the epaa.py script, which is called by the PEPTIDE_PREDICTION process.

Related issues:
#54
#130

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@christopher-mohr
Copy link
Collaborator

I will have a look. 👍
Could you also please change conda and the containers in the process here. Should be bioconda::epytope and quay.io/biocontainers/epytope. I think you might have to specify the tag as well. If it works the test should pass as well.

@christopher-mohr
Copy link
Collaborator

There was a permission problem with the bioconda container which is fixed now. The container can now be pulled from http://quay.io/biocontainers/epytope:3.0.0--pyh5e36f6f_0.

Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things that need to be changed but overall it looks good. 👍

modules/local/peptide_prediction.nf Show resolved Hide resolved
bin/epaa.py Outdated Show resolved Hide resolved
bin/epaa.py Show resolved Hide resolved
bin/epaa.py Show resolved Hide resolved
bin/epaa.py Show resolved Hide resolved
bin/epaa.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some of the tests are failing because of an epytope issue which will be solved in the new release.

@christopher-mohr christopher-mohr merged commit b682303 into nf-core:switch_to_epytope Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants