Batch resourcelimit update pipeline-level institutional configs #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfy133
requested review from
zhan4429,
DoaneAS,
njspix,
apeltzer,
CarsonJM,
edmundmiller,
alyssa-ab,
ahepperla,
alanhoyle,
gregorysprenger,
kviljoen,
ashildv,
davidecarlson,
priyanka-surana,
pvanheus,
BrunoGrandePhD,
theoportlock,
sofstam,
ewels,
maxulysse,
pontus,
georgiesamaha,
RoganGrant,
praveenraj2018,
BarryDigby,
adrlar,
lusacristan,
abretaud and
wassimsalam01
as code owners
jfy133
requested review from
maxulysse,
chris-cheshire,
apeltzer,
phue,
pvanheus,
adrlar,
DoaneAS and
ameynert
and removed request for
pontus,
marchoeppner,
drejom,
abretaud,
alanhoyle,
ewels,
olgabot,
maxulysse,
chris-cheshire,
apeltzer,
phue,
adrlar,
pvanheus,
DoaneAS and
ameynert
|
@sofstam @TCLamnidis this will (on merging of the other PR) only be related to us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DSL2 pipelines, we just strip as normal as resourceLimits should be inherited from the main institutional config.
The remaining acrtive DSL1 pipeline (eager) I've copied the check_max function into the file itself, until eager is converted to DSL2
Requires #757 before merging