Updated to reflect RMQ message model #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumped the graylog image to 3.3
* Increased the version of some of the images * Updated the services to fall in line with how the offical graylog documentation has them * Set the container names explicitly * Mounting the /usr/share/graylog/plugin volume explicitly so the jar can be manually built and copied into place
* Added some logging * Modified the configuration options. The 'queue' has been removed in favor of an 'exchange'. This is because the core model in RMQ is "a producer never sends any messages directly to a queue". * Added an optional routing_key configuration option. * Removed the Configuration check. This is done within the Graylog library itself so I wasn't sure that it was warranted. * Added a mandatory configuration item of 'vhost'. This will allow connecting to the non-default vhost.
* Added new configuration options. * Increased the logging verbosity * Create a dummy channel so that we can validate an exchange exists. If it doesn't then we'll use the proper channel to create it, otherwise we just move on. * Modified the basicPublish to use the routing_key
* Updating.
* Closing the dummy channel after a successful exchange validation. * Adding some additional logging.
* Setting the RMQ Password config with the IS_PASSWORD attribute.
* Updating latest version to 2.0.0
Closed
|
Hi! thanks for bringing this in! Can you update build instructions for getting your MR work with 3.2? |
|
Hey @romansavrulin I'm not sure I follow. Is this something in the |
|
@mjtice Looks like I've used the wrong word =)) I mean instructions. Anyway I've already found steps to build 2.0 and trying your MR in production. Thanks for your effort, once again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12, essentially this PR modifies the way messages are published into RMQ. The "official" model for publishing messages is that:
So I've modified the config to:
a. specify a vhost
b. specify an exchange vs. a queue.
This will allow publishing to a non-default vhost into an exchange. If the exchange doesn't exist one will be declared (direct, durable).