Bump to 0.2.3 #279
Merged
Bump to 0.2.3 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
duc-nx
force-pushed
the
pr279
branch
2 times, most recently
from
b90487a
to
68cebbb
Compare
duc-nx
commented
Aug 21, 2024
sjudson
approved these changes
Aug 21, 2024
yoichi-nexus
approved these changes
Aug 21, 2024
duc-nx
changed the title
cycles features in guest in host command
sjudson
requested changes
Aug 21, 2024
| @@ -137,9 +137,8 @@ fn setup_crate(host_path: PathBuf, rev: Option<String>, tag: Option<String>) -> | |||
| fp2, | |||
| concat!( | |||
| "\n", | |||
| "# Generated by cargo-nexus, do not remove!\n", | |||
There was a problem hiding this comment.
Oh I would leave this line in, just remove the one beneath about "This profile".
Summary: Fix missing `cycles` features in guest in host command. Test Plan: Update `test_sdk.sh` to catch missing feature bugs.
sjudson
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix missing
cyclesfeatures in guest in host command.Test Plan:
Update
test_sdk.shto catch missing feature bugs.