Skip to content

Commit

Permalink
Add Nova Public Parameter benchmark for SDK
Browse files Browse the repository at this point in the history
Summary:

Test Plan:
  • Loading branch information
duc-nx committed Aug 13, 2024
1 parent 6c88c1c commit fca0593
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,12 @@ jobs:
run: |
cargo bench --bench riscv_machine
bench-nova-public-params:
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'benchmark')
steps:
- uses: actions/checkout@v4
- name: Run benchmarks
run: |
cargo bench --bench nova_public_parameter_generation
13 changes: 12 additions & 1 deletion sdk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,25 @@ categories = { workspace = true }
[dependencies]
serde.workspace = true

nexus-core = { path = "../core", features = ["prover_nova", "prover_jolt", "prover_hypernova"] }
nexus-core = { path = "../core", features = [
"prover_nova",
"prover_jolt",
"prover_hypernova",
] }
nexus-macro = { path = "../macro" }
postcard = { version = "1.0.8", features = ["alloc"] }
uuid = { version = "1.9.1", features = ["v4", "fast-rng"] }
thiserror = "1.0.61"

[dev-dependencies]
nexus-profiler = { path = "../macro/profiler" }
criterion = "0.5.1"
iai-callgrind = "0.12.2"

[lib]
doctest = false

[[bench]]
name = "nova_public_parameter_generation"
harness = false

21 changes: 21 additions & 0 deletions sdk/benches/nova_public_parameter_generation.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
use criterion::{criterion_group, criterion_main, Criterion};
use nexus_sdk::nova;
use nexus_sdk::Parameters;

fn nova_public_parameter_generation() {
nova::seq::PP::generate_for_testing().expect("Failed to generate Nova public parameters");
}

#[allow(clippy::redundant_closure)]
fn bench_nova_public_parameter(c: &mut Criterion) {
c.bench_function("nova_public_parameter", |b| {
b.iter(|| nova_public_parameter_generation())
});
}

criterion_group!(
name = benches;
config = Criterion::default().significance_level(0.1).sample_size(10);
targets = bench_nova_public_parameter);

criterion_main!(benches);

0 comments on commit fca0593

Please sign in to comment.