Remove versioned attribute from Resource interface
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute only served as an alias to determine if the optional attributes `firstUpdated|dates|nVersions|updateCadence` are available. It's more direct (and preferred by the compiler) to check for presence of the individual attributes directly where needed. `versioned` at the top level on ListResourcesResponsiveProps is still valuable and should be kept.
jameshadfield
approved these changes
Jun 5, 2024
|
Added testing notes in the PR checklist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This attribute only served as an alias to determine if the optional attributes
firstUpdated|dates|nVersions|updateCadenceare available. It's more direct (and preferred by the compiler) to check for presence of the individual attributes directly where needed.versionedat the top level on ListResourcesResponsiveProps is still valuable and should be kept.Related issue(s)
Checklist
Check if changes affect the resource index JSON revision