Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update test-pathogen-repo-ci #85

Merged
merged 2 commits into from
Jul 22, 2024
Merged

CI: Update test-pathogen-repo-ci #85

merged 2 commits into from
Jul 22, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Jul 16, 2024

Description of proposed changes

Add comments to clearly show the job using pathogen-repo-ci@v0 is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to a old tag of the pathogen-repo-ci, the job should not be expected to be updated.

Any new pathogen repos should be added to the test-pathogen-repo-ci job which uses the latest version of pathogen-repo-ci.

Related issue(s)

Prompted by #83 (comment)
Resolves #78
Related to nextstrain/.github#84

Checklist

  • Checks pass

@joverlee521 joverlee521 marked this pull request as ready for review July 17, 2024 00:02
@joverlee521 joverlee521 requested a review from a team July 17, 2024 00:03
@joverlee521 joverlee521 mentioned this pull request Jul 19, 2024
1 task
joverlee521 added a commit to nextstrain/docker-base that referenced this pull request Jul 19, 2024
As per @victorlin 's recommendation in related change in conda-base,¹
these pathogens can get updated as post-merge tasks for eventual PRs.

¹ <nextstrain/conda-base#85 (comment)>
joverlee521 added a commit to nextstrain/augur that referenced this pull request Jul 19, 2024
As per @victorlin 's recommendation in related change in conda-base,¹
these pathogens can get updated as post-merge tasks for eventual PRs.

¹ <nextstrain/conda-base#85 (comment)>
Add comments to clearly show the job using pathogen-repo-ci@v0 is for
pathogen repos that do not conform to the standard pathogen repo
structure. Since these are tied to a old tag of the `pathogen-repo-ci`,
the job should not be expected to be updated.

Any new pathogen repos should be added to the `test-pathogen-repo-ci`
job which uses the latest version of `pathogen-repo-ci`.
@joverlee521 joverlee521 merged commit 1f696ad into main Jul 22, 2024
3 checks passed
@joverlee521 joverlee521 deleted the update-ci branch July 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable zika/mpox pathogen repo ci
3 participants