Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add cache for Micromamba installation #57

Closed
wants to merge 1 commit into from

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jan 17, 2024

Description of proposed changes

This endpoint sometimes fails to resolve, so caching as a fallback should help.

Related issue(s)

Checklist

  • Cache hit and updated during CI re-run
  • Checks pass

@victorlin victorlin self-assigned this Jan 17, 2024
@victorlin victorlin force-pushed the victorlin/ci-cache-micromamba branch from 7581173 to da17dd2 Compare January 17, 2024 22:07
@victorlin victorlin marked this pull request as ready for review January 17, 2024 22:31
@victorlin victorlin requested a review from a team January 17, 2024 22:32
Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out a way to reduce failure rate.

This way we might never get updates from mamba.

Should we maybe use the cache only if the install fails?

Or run the cache first, then install second even if the cache hit so we pull changes?

This endpoint sometimes fails to resolve, so caching as a fallback
should help.
@victorlin victorlin force-pushed the victorlin/ci-cache-micromamba branch from 15d7723 to 6aead8f Compare January 18, 2024 01:02
Comment on lines +55 to +59
- name: Save Micromamba to cache
uses: actions/cache/save@v4
with:
path: ~/.local/bin/micromamba
key: ${{ runner.os }}-micromamba
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some more work - it didn't save.

Failed to save: Unable to reserve cache with key Linux-micromamba, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/57/merge, Key: Linux-micromamba, Version: 53670150c936a15bf347fc758f8d4ffb00bfaed7e1251039dfd6945875b46746
Warning: Cache save failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, that's a shame :(

@victorlin victorlin marked this pull request as draft January 18, 2024 02:01
@tsibley
Copy link
Member

tsibley commented Jan 18, 2024

Caching this way seems error prone to me, so I'd personally avoid it.

If resolving micro.mamba.pm is a repeat issue (but other resolution works fine…?), then we could try fetching https://raw.githubusercontent.com/mamba-org/micromamba-releases/main/install.sh instead of https://micro.mamba.pm/install.sh.

@victorlin
Copy link
Member Author

Good suggestion @tsibley. Closing in favor of #58

@victorlin victorlin closed this Jan 18, 2024
@victorlin victorlin deleted the victorlin/ci-cache-micromamba branch January 18, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Transient failures during Micromamba installation
3 participants