Handle PUE param #16
Merged
Handle PUE param #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
reviewed
Jul 28, 2023
plugins/nf-co2footprint/src/main/nextflow/co2footprint/CO2FootprintConfig.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-co2footprint/src/main/nextflow/co2footprint/CO2FootprintFactory.groovy
Show resolved
Hide resolved
mirpedrol
approved these changes
Jul 28, 2023
|
Thanks @mirpedrol ! |
skrakau
force-pushed
the
handle_pue_param
branch
2 times, most recently
from
8d5b752
to
22b2ea0
Compare
skrakau
force-pushed
the
handle_pue_param
branch
from
22b2ea0
to
67d8b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the PUE value to the config and added another test for this.
Defining the default PUE value in the
CO2FootprintConfigclass is inconsistent with the handling of thefileandsummaryFileparameters, whose defaults are defined in theCO2FootprintFactoryclass (CO2FootprintTextFileObserversubclass). But maybe this can be restructured when we have all parameters handled properly. Or do you have already a suggestion?