Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Azure Fusion env misses credentials when no key or SAS provided #5287

Closed
wants to merge 15 commits into from
Closed

fix: Azure Fusion env misses credentials when no key or SAS provided #5287

wants to merge 15 commits into from

Commits on Sep 5, 2024

  1. Fix: Azure Fusion missing authentication if accountKey is provided 

    Changes logic of Azure Environment set up:

1. Is there an account name? (no: error)
2. Is there an accountKey or an accountSas or Managed identity? (no: error)
3. If there is a managed identity
    yes: return
    no: Create or add a SAS -> return

Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    92c974c View commit details
    Browse the repository at this point in the history

  2. Catch when service principal exists but no keys or SAS 

    Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    89710df View commit details
    Browse the repository at this point in the history

  3. Mock AzStorageOpts 

    Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a6006f0 View commit details
    Browse the repository at this point in the history

  4. Improve comment for Fusion env with SAS 

    Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0171fa3 View commit details
    Browse the repository at this point in the history

  5. Update plugins/nf-azure/src/main/nextflow/cloud/azure/fusion/AzFusion… 

    …Env.groovy

Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8b92f8f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Ensure proper SAS tokens are generated for each Azure authentication … 

    …method

Signed-off-by: Alberto Miranda <[email protected]>
    @alberto-miranda
    alberto-miranda committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f11d62d View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. test [platform stage] 

    Signed-off-by: Paolo Di Tommaso <[email protected]>
    @pditommaso
    pditommaso committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dd20318 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_azure_fusion_missing_auth

    @pditommaso
    pditommaso committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a832bde View commit details
    Browse the repository at this point in the history

  3. test [platform stage] 

    Signed-off-by: Paolo Di Tommaso <[email protected]>
    @pditommaso
    pditommaso committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    61374f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'master' into fix_azure_fusion_missing_auth

    @adamrtalbot
    adamrtalbot authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5b67abe View commit details
    Browse the repository at this point in the history

  2. [platform stage] 

    Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3139dae View commit details
    Browse the repository at this point in the history

  3. debug build workflow 

    Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cab3ffe View commit details
    Browse the repository at this point in the history

  4. Revert "debug build workflow" 

    This reverts commit cab3ffe.

Signed-off-by: adamrtalbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d05cae5 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'master' into fix_azure_fusion_missing_auth

    @pditommaso
    pditommaso committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    577bfb4 View commit details
    Browse the repository at this point in the history

  2. test [e2e stage] 

    Signed-off-by: Paolo Di Tommaso <[email protected]>
    @pditommaso
    pditommaso committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f93e25b View commit details
    Browse the repository at this point in the history