Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.md for mklink #5169

Closed
wants to merge 1 commit into from
Closed

Conversation

bjlang
Copy link

@bjlang bjlang commented Jul 26, 2024

The documentation for mklink indicates options as 2nd parameter ( mklink( linkName, options = [:] ) ), however they need to be provided as 1st parameter, following the function signature ( mklink(java.util.Map opts, java.nio.file.Path link) )

The documentation for mklink indicates options as 2nd parameter ( mklink( linkName, options = [:] ) ), however the need to be provided as 1st parameter without key, following the function signature ( mklink(java.util.Map opts, java.nio.file.Path link) )

Signed-off-by: Björn Langer <[email protected]>
@bjlang bjlang requested a review from a team as a code owner July 26, 2024 13:42
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit aaade88
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66a3a7e1f3d1bb000881150f
😎 Deploy Preview https://deploy-preview-5169--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentsherman
Copy link
Member

Named args can be specified in any order. Groovy collects them into a Map and passes it as the first argument.

Though I see your point that if you provided an explicit map rather than named args, you would need to provide it first. I think we can clarify the docs by saying [options] instead of options = [:], but we'll need to do that across the board. I will make a PR for this. Thanks for your suggestion

@bentsherman
Copy link
Member

Closing in favor of #5171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants