Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(paragraph): migrate preview options to decorations #6430

Merged
merged 13 commits into from
Sep 23, 2024
Merged

[stable29] fix(paragraph): migrate preview options to decorations #6430

merged 13 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. enh: add extractLinkParagraphs 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c4d27a4 View commit details
    Browse the repository at this point in the history

  2. refactor(test): reuse link string 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8445411 View commit details
    Browse the repository at this point in the history

  3. enh(preview): include previews in list of link paragraphs 

    Render the preview options as a decoration for previews too.

Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    eb52636 View commit details
    Browse the repository at this point in the history

  4. feat(previewOptions): Migrate preview options to prosemirror decorations 

    Fixes: #6185

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1dc5c12 View commit details
    Browse the repository at this point in the history

  5. chore(preview): Remove PreviewOptions from Paragraph and Preview 

    Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cfcdb2b View commit details
    Browse the repository at this point in the history

  6. enh(preview): add nodeSize in decoration data structure 

    Required for implementing `deleteNode` like tiptap does it:
https://github.com/ueberdosis/tiptap/blob/develop/packages/core/src/NodeView.ts#L305

Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d9f45f1 View commit details
    Browse the repository at this point in the history

  7. fix(preview): use deleteRange to remove the node 

    Compute the range based on offset and nodeSize.

Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d868799 View commit details
    Browse the repository at this point in the history

  8. fix(preview): Fix alignment of preview options 

    - center align options for text links
- top align options for preview links

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    339cf5b View commit details
    Browse the repository at this point in the history

  9. fix(paragraph): get rid of superfluous ParagraphView component 

    Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c23ece2 View commit details
    Browse the repository at this point in the history

  10. fix(preview): Don't let preview options container overlay paragraph 

    Otherwise the overlay container would catch all the click events.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4e61794 View commit details
    Browse the repository at this point in the history

  11. fix(preview): Fix some linting issues 

    Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aa7e86a View commit details
    Browse the repository at this point in the history

  12. test(cy): Fix selectors for paragraphs in cypress tests 

    Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    67ce990 View commit details
    Browse the repository at this point in the history

  13. fix(preview): Further improvements 

    * Don't calculate preview options decorations in readonly editor
* Check for changed nodeSize when checking for decoration changes
* Rename `editor` to `$editor` in vue compontent, it's not reactive

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    42960f7 View commit details
    Browse the repository at this point in the history