Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Make build run without additional ram #5818

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

WIP: Make build run without additional ram #5818

wants to merge 17 commits into from

Commits on May 21, 2024

  1. enh(editorFactory): only use named exports 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d275d0b View commit details
    Browse the repository at this point in the history

  2. cleanup(deps): remove proxy-polyfill 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0d8f3b2 View commit details
    Browse the repository at this point in the history

  3. cleanup(EditorFactory): inline serializPlainText 

    Also drop the content arg to the serialize function
as it is never provided

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f2609f5 View commit details
    Browse the repository at this point in the history

  4. enh(serialize): also use markdown approach for plaintext 

    We simply overwrite the `toMarkdown` function
and then rely on that.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cb72b03 View commit details
    Browse the repository at this point in the history

  5. enh(Serializer): split from Markdown extension 

    We are now using this for serializing plaintext as well.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0c89a2e View commit details
    Browse the repository at this point in the history

  6. refactor(Editor): move initialization into onOpened 

    We do need the session for initialization
but we do not need the `documentSource` or `documentState` anymore

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d478878 View commit details
    Browse the repository at this point in the history

  7. refactor(Serializer): make _createMarkdownSerializer internal 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    00a82fb View commit details
    Browse the repository at this point in the history

  8. fix(lint): only default export Serializer 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    43355d2 View commit details
    Browse the repository at this point in the history

  9. fix(lint): fix all warnings 

    * Use const arrow functions when no doc comment is needed.
* Use the tiptap api to inspect editor state
  rather than reaching deep into the editor state.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3df0294 View commit details
    Browse the repository at this point in the history

  10. refactor(syncService): do not expose serialize() 

    Keep as `#getContent` internally.

Use `serializeEditorContent(editor)`
outside of the `SyncService`.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3559f13 View commit details
    Browse the repository at this point in the history

  11. refactor(Markdown): simplify serialization logic 

    The intermediate object with `serialize` and `serializer`
is not needed anymore.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7af0c9e View commit details
    Browse the repository at this point in the history

  12. refactor(Editor.vue): use editor events not callbacks 

    No need pass the callbacks in createEditor.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    de6411d View commit details
    Browse the repository at this point in the history

  13. refactor(Editor.vue): early return for reconnects 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    40847ba View commit details
    Browse the repository at this point in the history

  14. fix(lint): also lint .ts files 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e74c520 View commit details
    Browse the repository at this point in the history

  15. refactor(EditorFactory): split createRichEditor and createPlainEditor 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d489836 View commit details
    Browse the repository at this point in the history

  16. cleanup(RichText): unused component option 

    Seems to be unused at the moment.
Also did not find any use for it in the commit that introduced it.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0cd8d8b View commit details
    Browse the repository at this point in the history

  17. refactor(Editor): split async createEditor from onOpened 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 21, 2024
    Configuration menu
    Copy the full SHA
    fae0ddf View commit details
    Browse the repository at this point in the history