Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several link handling fixes #5422

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Several link handling fixes #5422

merged 7 commits into from
Mar 1, 2024

Commits on Feb 28, 2024

  1. fix(LinkBubble): Remove custom blur/focus handling 

    No longer hide the link bubble when editor looses focus. We just always
show the link bubble as long as the selection stays within a link or
until it's manually closed.

This eliminates possible race-conditions and corner-case bugs.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    352108d View commit details
    Browse the repository at this point in the history

  2. test(cypress): Don't hide LinkBubble on scroll event in Cypress 

    Prevents annoying race conditions when testing the LinkBubble in
Cypress.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    90a4f0d View commit details
    Browse the repository at this point in the history

  3. fix(link): Insert full URLs for links to Nextcloud files 

    Full URLs have the advantage that they also work when clicking them
outside the Nextcloud context, e.g. in a local markdown editor.

Their main disadvantage is that they cause trouble on Nextcloud
instances with more than one hostname or after changing the hostname of
a Nextcloud instance.

The first use case (opening a file outside Nextcloud context) is more
likely and less of a corner case than the second (changing hostname), so
we decided to go for full URLs.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1dc9ec4 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. fix(LinkBubble): Use debounce instead of custom debounce implementation 

    Run `updateFromSelection()` immediately on first call and only delay
further runs.

This fixes a race condition with `this.#hadUpdateFromClick` which gets
set when updating from click and gets cleaned up after 200ms.

Fixes an issue with the bubble disappearing immediately when clicking on
a link after unfocussed browser and editor.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9557ab8 View commit details
    Browse the repository at this point in the history

  2. fix(link): Don't rewrite links with fileId inside Collectives 

    Required to allow relative links (and those without origin) to other
collectives pages to be resolved by link previews.

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    40f539d View commit details
    Browse the repository at this point in the history

  3. fix(link): Prevent middle-click from opening two tabs on Firefox 

    Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9bd0d00 View commit details
    Browse the repository at this point in the history

  4. fix(ActionInsertLink): Sync NcActionInput value property 

    Fixes: #5324

Signed-off-by: Jonas <[email protected]>
    @mejo-
    mejo- committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0dd249c View commit details
    Browse the repository at this point in the history