Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/preview links #5399

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Enh/preview links #5399

merged 12 commits into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. enh(nodes): introduce preview node 

    Use title attribute to mark previews in markdown.

Introduce PreviewOptions component
to add preview options for isolated links.
If there's just one link in a paragraph
you can turn it into a preview.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    94949bc View commit details
    Browse the repository at this point in the history

  2. test(cy): make node test helpers available 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    fe74b7b View commit details
    Browse the repository at this point in the history

  3. enh(preview): togglePreview to return false when not possible 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0d8c165 View commit details
    Browse the repository at this point in the history

  4. enh(Preview): split togglePreview in setPreview and unsetPreview 

    They actually need to do different things
due to the different structure.

On the one hand we have the preview node
with plain text content.
And on the other hand a paragraph node
with the text wrapped in a link mark.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9127692 View commit details
    Browse the repository at this point in the history

  5. test(preview): adjust jest tests 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1fc7bb7 View commit details
    Browse the repository at this point in the history

  6. refactor(preview): use selection in the function args 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5453b33 View commit details
    Browse the repository at this point in the history

  7. enh(preview): make use of setPreview without args 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    eac2bf1 View commit details
    Browse the repository at this point in the history

  8. fix: get rid of link in preview to avoid popup 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    75f5479 View commit details
    Browse the repository at this point in the history

  9. fix(preview): hide tooltip for links in preview 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1ee3cbd View commit details
    Browse the repository at this point in the history

  10. fix(preview): set selection inside the node 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    544bfb6 View commit details
    Browse the repository at this point in the history

  11. test(preview): do not run commands in Preview md test 

    They convert the node without changing the content
resulting in an endless loop.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    dd12e5a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. style: Fix eslint errors 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fecb336 View commit details
    Browse the repository at this point in the history