fix: Add alt attribute to image nodes #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
mejo-
approved these changes
Feb 19, 2024
AndyScherzinger
approved these changes
Feb 19, 2024
|
/backport to stable28 |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/5393/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8a3c21a0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5393/stable28Error: Failed to clone repository: Failed to clone and cache repo: Cloning into '.'... Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable28 |
susnux
reviewed
Feb 22, 2024
| @@ -41,6 +41,7 @@ | |||
| <div class="media__wrapper"> | |||
| <img v-show="loaded" | |||
| :src="imageUrl" | |||
| :alt="alt" | |||
| class="image__main" | |||
| @load="onLoaded"> | |||
| <div class="metadata"> | |||
There was a problem hiding this comment.
@juliushaertl maybe we should hide the span below (class="name") for a11y? meaning making it aria-hidden="true". Because it duplicates the alt tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
It seems otherwise browser would read out the full URL with screen readers. We already have the alt text as user defined description for each image so we should make use of that.