fix(css): Fix print view in viewer and single-file share #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Fixes: #4536 Signed-off-by: Jonas <[email protected]>
Compare print view of long document visually using `cypress-visual-regression` to detect regressions in print view in the future. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/print_css
branch
4 times, most recently
from
fda43c5
to
9b666c9
Compare
|
/compile |
|
The snapshot comparison will only succeed after the JS assets got updated. So let's try to compile+push them into the PR. |
juliushaertl
approved these changes
Nov 29, 2023
|
Nah, looks like the font stack used by your local snapshots is different from CI 🙈 |
… share Visually compare print view of long document in single-file share. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Yeah, the joy of visual comparison tests 🤪 I updated it now with the snapshots created by CI. |
|
/backport to stable28 |
|
/backport 90ce11e,aff3a1add26cf0edc12f2c624c4a109edf320a46,280948b35e63b46cbf446657c73492343bf4f79d,035f5cc900528277b3ead8e8640e885cb80af949,a73f1f339f78aed55c7f2efc28e384ff3e39a641,9af378da3ba7675db4b3f2f9244c8b4e1d923bd0,624651e86f7f681f51fa8e35931f4ab9a6f33a87,5c7d3918dbc790273aa6a9dacf2c36f701b7d7ea to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Also adds screenshot comparison tests for print view in viewer and single-file share.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)