Refactor attachment loading

[mejo-]

📝 Summary

Introduces an API endpoint to fetch a list of native attachments (all files in .attachments.<fileId> folder). Frontend fetches this list when AttachmentResolver is initialized and uses it when resolving attachments.

The main advantage is that all metadata about native attachments is available instantaneously. This obsoletes the logic to iterate through candidates in the frontend code for determining whether it's an image or non-image attachment.

Additionally, it allows to decide in frontend what to do with non-image attachments. When viewer is available and not in use, supports the attachment mimetype and we're not in a public share, we open the attachment in viewer now. Otherwise we download the attachment.

The editor API now uses MarkdownContentEditor.vue when fileId is passed along with useSession = false. We need the fileId in MarkdownContentEditor.vue for using the AttachmentResolver in a meaningful way. Also required: the backend allows to get the attachment list without a document session.

Also:

• Fixes several issues with ShowImageModal
• Fixes setting the filename for returned attachments
• Removes support for obsolete text:// syntax
• Removes support for hasPreview=true query parameter in attachment URLs
• Removes special-handling of attachment preview URLs (/core/preview/)
• Removes obsolete metadata API endpoint
• Resolves: Use list of own attachment files in AttachmentResolver #3974
• Resolves: Opening non-image attachments is broken #3849, a pdf file attached to a "text"(.md) file does not open #4723, attach a pdf file to a markdown file #5030

🚧 TODO

• fallback in frontend resolver: update list if attachment is not found
• generate full image/media URL in backend
• generate preview (image/mediaPreview) URL in backend
• get rid of getMediaMetadataUrl in frontend
• Move to RequireDocumentSessionUserOrShareToken in all read-only endpoints of
  AttachmentController.
• Check access of user/shareToken to document in SessionMiddleware

additional scenarios

• In public share (Editor.vue)
• Read-only in public share (Editor.vue)
• Without session (MarkdownContentEditor.vue)
• Without session in public share (MarkdownContentEditor.vue)
• Attachment is added during session (Editor.vue)
• Delete and re-add attachment in session, works for other clients?
• Upload several attachments at once
• Test direct URL (image & media) to full URL on same instance
• Test URL with .attachments/<wrongId>
• [-] Test data:... image
  • [-] Text opening in modal
• Test all scenarios with missing attachments file (image & media)
• Test opening image (image modal)
  • In Editor.vue with session and user in Text/Viewer
  • In Editor.vue with session and user in Collectives
  • In Editor.vue with session and public share in Text/Viewer
  • In Editor.vue with session and public share in Text standalone (single-file share)
  • In Editor.vue with session and public share in Collectives
  • In MarkdownEditor.vue without session with user in Collectives
  • In MarkdownEditor.vue without session in public share in Collectives
• Test attachment with (pdf) & without viewer support (tar.gz)
  • In Editor.vue with session and user in Text/Viewer
  • In Editor.vue with session and user in Collectives
  • In Editor.vue with session and public share in Text/Viewer
  • In Editor.vue with session and public share in Text standalone (single-file share)
  • In Editor.vue with session and public share in Collectives
  • In MarkdownEditor.vue without session with user in Collectives
  • In MarkdownEditor.vue without session in public share in Collectives

questions

• what is this hasPreview=true URL parameter about?

further

• Delete legacy text:// syntax support
• Delete &hasPreview=true support
• Get rid of imageFileId(), getQueryVariable(), isSupportedImage() in ImageView.vue
• Error message in caption on image load error
• open non-native images in ShowImageModal
• ensure correct order (similar to in document) in ShowImageModal
• open non-image attachments in viewer/new tab
  • Get rid of internalLinkOrImage() in ImageView.vue
  • Open in public share

tests

• mock AttachmentController response and test AttachmentService logic
• open image in Text in viewer (->image modal)
• open tar.gz attachment in Text in viewer (->download)

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation is not required

[juliusknorr]

Some first feedback :)

[juliusknorr]

Some more comments, but look great so far already.

[juliusknorr]

/backport to stable28

[juliusknorr]

/backport to stable27