Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid layout jump with rich workspace #4776

Merged
merged 4 commits into from
Sep 8, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Listeners/FilesLoadAdditionalScriptsListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
return;
}

\OCP\Util::addInitScript('text', 'text-init');

Check failure on line 48 in lib/Listeners/FilesLoadAdditionalScriptsListener.php

View workflow job for this annotation

GitHub Actions / Nextcloud

UndefinedMethod

lib/Listeners/FilesLoadAdditionalScriptsListener.php:48:3: UndefinedMethod: Method OCP\Util::addinitscript does not exist (see https://psalm.dev/022)
\OCP\Util::addScript('text', 'text-files');

$this->initialStateProvider->provideState();
Expand Down
6 changes: 1 addition & 5 deletions src/files.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@
*/
import { linkTo } from '@nextcloud/router'
import { loadState } from '@nextcloud/initial-state'
import { registerFileListHeaders } from '@nextcloud/files'
import Vue from 'vue'

import { logger } from './helpers/logger.js'
import { registerFileActionFallback, FilesWorkspaceHeader } from './helpers/files.js'
import { registerFileActionFallback } from './helpers/files.js'
import FilesSettings from './views/FilesSettings.vue'
import store from './store/index.js'

Expand Down Expand Up @@ -56,9 +55,6 @@ document.addEventListener('DOMContentLoaded', () => {
}

})
if (workspaceAvailable) {
registerFileListHeaders(FilesWorkspaceHeader)
}

OCA.Text = {
RichWorkspaceEnabled: workspaceEnabled,
Expand Down
6 changes: 6 additions & 0 deletions src/helpers/files.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ export const FilesWorkspaceHeader = new Header({

render(el, folder, view) {
addMenuRichWorkspace()
const hasRichWorkspace = !!folder.attributes['rich-workspace-file']

import('vue').then((module) => {
el.id = 'files-workspace-wrapper'
Expand All @@ -201,14 +202,19 @@ export const FilesWorkspaceHeader = new Header({
vm = new View({
propsData: {
path: folder.path,
hasRichWorkspace,
content: folder.attributes['rich-workspace'],
},
store,
}).$mount(el)
})
},

updated(folder, view) {
const hasRichWorkspace = !!folder.attributes['rich-workspace-file']
vm.path = folder.path
vm.hasRichWorkspace = hasRichWorkspace
vm.content = folder.attributes['rich-workspace']
},
})

Expand Down
12 changes: 12 additions & 0 deletions src/init.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { registerFileListHeaders, registerDavProperty } from '@nextcloud/files'
import { loadState } from '@nextcloud/initial-state'
import { FilesWorkspaceHeader } from './helpers/files.js'

const workspaceAvailable = loadState('text', 'workspace_available')

registerDavProperty('nc:rich-workspace', { nc: 'http://nextcloud.org/ns' })
registerDavProperty('nc:rich-workspace-file', { nc: 'http://nextcloud.org/ns' })

if (workspaceAvailable) {
registerFileListHeaders(FilesWorkspaceHeader)
}
36 changes: 23 additions & 13 deletions src/views/RichWorkspace.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@

<template>
<div v-if="enabled"
v-show="file"
v-show="hasRichWorkspace"
id="rich-workspace"
:class="{'focus': focus, 'dark': darkTheme, 'creatable': canCreate }">
<SkeletonLoading v-if="!loaded || !ready" />
:class="{'focus': focus, 'dark': darkTheme }">
<RichTextReader v-if="!loaded || !ready" :content="content" class="rich-workspace--preview" />
<Editor v-if="file"
v-show="ready"
:key="file.path"
Expand All @@ -48,19 +48,23 @@
import axios from '@nextcloud/axios'
import { generateOcsUrl } from '@nextcloud/router'
import { subscribe, unsubscribe } from '@nextcloud/event-bus'
import SkeletonLoading from '../components/SkeletonLoading.vue'
import getEditorInstance from '../components/Editor.singleton.js'
import RichTextReader from '../components/RichTextReader.vue'

const IS_PUBLIC = !!(document.getElementById('isPublic'))
const WORKSPACE_URL = generateOcsUrl('apps/text' + (IS_PUBLIC ? '/public' : '') + '/workspace', 2)

export default {
name: 'RichWorkspace',
components: {
SkeletonLoading,
RichTextReader,
Editor: getEditorInstance,
},
props: {
content: {
type: String,
default: '',
},
path: {
type: String,
required: true,
Expand All @@ -69,6 +73,10 @@ export default {
type: Boolean,
default: true,
},
hasRichWorkspace: {
type: Boolean,
default: false,
},
},
data() {
return {
Expand All @@ -87,9 +95,6 @@ export default {
shareToken() {
return document.getElementById('sharingToken')?.value
},
canCreate() {
return !!(this.folder && (this.folder.permissions & OC.PERMISSION_CREATE))
},
},
watch: {
path() {
Expand Down Expand Up @@ -134,9 +139,12 @@ export default {
})
},
getFileInfo(autofocus) {
this.loaded = false
this.autofocus = false
if (!this.hasRichWorkspace) {
return
}
this.ready = false
this.loaded = true
this.autofocus = false
const params = { path: this.path }
juliusknorr marked this conversation as resolved.
Show resolved Hide resolved
if (IS_PUBLIC) {
params.shareToken = this.shareToken
Expand Down Expand Up @@ -209,9 +217,11 @@ export default {
transition: max-height 0.5s cubic-bezier(0, 1, 0, 1);
z-index: 61;
position: relative;
&.creatable {
min-height: 100px;
}
min-height: 30vh;
}

.rich-workspace--preview {
margin-top: 44px;
}

/* For subfolders, where there are no Recommendations */
Expand Down
1 change: 1 addition & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ webpackConfig.entry = {
public: path.join(__dirname, 'src', 'public.js'),
viewer: path.join(__dirname, 'src', 'viewer.js'),
editors: path.join(__dirname, 'src', 'editor.js'),
init: path.join(__dirname, 'src', 'init.js'),
}

webpackConfig.output.chunkFilename = '[id].js?v=[contenthash]'
Expand Down
Loading