Bugfix/duplicated load of yjs

[luka-nextcloud]

📝 Summary

• Resolves: Prevent duplicate loading of yjs when workspace and viewer open text #3825

Reset value of window['__ $YJS$ __'] before Editor component is mounted to avoid console error Yjs was already imported.

🖼️ Screenshots

🏚️ Before	🏡 After
B	A

🚧 TODO

• ...

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

Passing run #11562 ↗︎

0

149

2

0

0

Details:

Bugfix/duplicated load of yjs
Project: Text	Commit: e80e8b1eb5
Status: Passed	Duration: 04:15 💡
Started: Aug 8, 2023 8:15 AM	Ended: Aug 8, 2023 8:20 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliushaertl]

Small comments, but the general approach looks good :) Haven't tested yet though

[max-nextcloud]

@luka-nextcloud I just had a brief look at this - you marked three conversations with julius as resolved but only one of them seems to be addressed (the timeout). I don't understand why you resolved the other ones. When you resolve a conversation without changes to the code - could you add a brief comment explaining why? That would make it easier to understand what is going on.

Thanks! ❤️

[luka-nextcloud]

@max-nextcloud All of the comments are resolved now.

[max-nextcloud]

/compile

[Taikaschi]

I still have this error in my browser console after upgrade to 27.1.0 final.

[max-nextcloud]

I still have this error in my browser console after upgrade to 27.1.0 final.

As far as i can tell this has not been backported to 27. I'll trigger a backport - not sure if we want to backport but we can discuss that in the backport PR.

[max-nextcloud]

/backport 94eca01 to stable27