-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: cypress failure on upload / CSRF / Session failure with 401 #4350
Conversation
Passing run #10766 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
4f9f742
to
2d3943b
Compare
cypress/support/commands.js
Outdated
.then(requesttoken => { | ||
cy.request('/csrftoken') | ||
.then(({ body }) => { | ||
const requesttoken = body.token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the duplicate then might cause timing issues, but no idea why, so far test runs on CI seem promising
a6bf7e3
to
08441b7
Compare
d8df69f
to
7878c70
Compare
09ba1c0
to
a30c171
Compare
Suspicious from the logs, the service worker request after login (possibly from an older context) does generate a new csrf token and fails with no user session
Possibly related cypress-io/cypress#16192 |
e5b79fb
to
1ddb70b
Compare
Another interesting log trace:
This case also still involves preview-service-worker.js
|
Another related one cypress-io/cypress#702 The workarounds to disable service workers in cypress doesn't seem to to the trick, but patched out the service worker part in the server seems promising for todays pushes: https://github.com/nextcloud/text/actions/workflows/cypress.yml?query=branch%3Acypress%2Fdebug |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
6bde41e
to
a77b579
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Closing as tests seem more stable now |
Signed-off-by: Julius Härtl [email protected]
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)