Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Move CSS files to src directory #4318

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 20, 2023

Move all files in css/ to the src/ directory since they are only used in the webpack build.

This has two positive effects:

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jun 20, 2023

2 failed and 2 flaky tests on run #10314 ↗︎

2 143 1 2 Flakiness 2

Details:

chore(css): Move CSS files to src directory
Project: Text Commit: b4244b0500
Status: Failed Duration: 11:22 💡
Started: Jun 20, 2023 9:36 AM Ended: Jun 20, 2023 9:48 AM
Failed  conflict.spec.js • 1 failed test

View Output Video

Test Artifacts
text/plain (lines.txt) > displays conflicts Output Screenshots
Failed  api/UsersApi.spec.js • 1 failed test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  nodes/HardBreak.spec.js • 1 flaky test

View Output Video

Test Artifacts
Hard break support > Convert paragraph break into hard break Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliushaertl
Copy link
Member Author

Failures unrelated

@juliushaertl juliushaertl merged commit 494493f into main Jun 20, 2023
29 of 32 checks passed
@juliushaertl juliushaertl deleted the build/move-css branch June 20, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants