Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display content first and then load menus #2226

Merged
merged 2 commits into from
Mar 8, 2022
Merged

display content first and then load menus #2226

merged 2 commits into from
Mar 8, 2022

Commits on Mar 7, 2022

  1. display content first and then load menus 

    Rendering the menubar and menububble takes a significant amount of time.
First display the content and then render the menus.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    a875a72 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. refactor: extract logic into computed 

    Also rename `initialLoading` in `EditorWrapper` to `contentLoaded`.
This flag is set during the `initialLoading` state change.
It does indicates that the loading happened
Use the past tense to indicate that.

The editor wrapper is now loading in different steps.
The menus will load after the content.
So `content` seems more fitting then `initial`.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    3ca1038 View commit details
    Browse the repository at this point in the history