fix: Throw if file has no owner

Signed-off-by: Julius Härtl <[email protected]>
nextcloud · Jul 24, 2023 · e2e8358 · e2e8358
1 parent 146aa5f
commit e2e8358
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/Service/AttachmentService.php b/lib/Service/AttachmentService.php
@@ -424,6 +424,9 @@ private function hasUpdatePermissions(string $shareToken): bool {
 	 */
 	private function getAttachmentDirectoryForFile(File $textFile, bool $create = false): Folder {
 		$owner = $textFile->getOwner();
+		if ($owner === null) {
+			throw new NotFoundException('File has no owner');
+		}
 		$ownerId = $owner->getUID();
 		$ownerUserFolder = $this->rootFolder->getUserFolder($ownerId);
 		$ownerTextFile = $ownerUserFolder->getById($textFile->getId());

diff --git a/psalm.xml b/psalm.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <psalm
-    errorLevel="4"
+    errorLevel="3"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"