Merge pull request #5401 from nextcloud/fix/collectives_no_link_rewrite

fix(link): Don't rewrite links with fileId inside Collectives

src/helpers/links.js

@@ -20,6 +20,7 @@
  *
  */
 
+import { loadState } from '@nextcloud/initial-state'
 import { generateUrl } from '@nextcloud/router'
 
 const absolutePath = function(base, rel) {
@@ -61,6 +62,10 @@ const domHref = function(node, relativePath) {
 	if (ref.startsWith('#')) {
 		return ref
 	}
+	// Don't rewrite URL in Collectives context
+	if (loadState('core', 'active-app') === 'collectives') {
+		return ref
+	}
 
 	const match = ref.match(/^([^?]*)\?fileId=(\d+)/)
 	if (match) {

src/tests/helpers/links.spec.js

@@ -1,4 +1,5 @@
 import { domHref, parseHref } from '../../helpers/links'
+import { loadState } from '@nextcloud/initial-state'
 
 global.OCA = {
 	Viewer: {
@@ -12,6 +13,9 @@ global.OC = {
 
 global._oc_webroot = ''
 
+jest.mock('@nextcloud/initial-state')
+loadState.mockImplementation((app, key) => 'files')
+
 describe('Preparing href attributes for the DOM', () => {
 
 	test('leave empty hrefs alone', () => {
@@ -103,3 +107,14 @@ describe('Inserting hrefs into the dom and extracting them again', () => {
 	})
 
 })
+
+describe('Preparing href attributes for the DOM in Collectives app', () => {
+	beforeAll(() => {
+		loadState.mockImplementation((app, key) => 'collectives')
+	})
+
+	test('relative link with fileid in Collectives', () => {
+		expect(domHref({attrs: {href: 'otherfile?fileId=123'}}))
+			.toBe('otherfile?fileId=123')
+	})
+})