Skip to content

Commit

Permalink
fix(MarkdownContentEditor): Respect onLoaded callback passed via API
Browse files Browse the repository at this point in the history
Emit `ready` once the editor is ready (Tiptap `create` event), which
causes the `onLoaded` callback passed via editor API to be called

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
mejo- authored and backportbot[bot] committed Mar 19, 2024
1 parent f89e144 commit b8513d6
Showing 1 changed file with 23 additions and 3 deletions.
26 changes: 23 additions & 3 deletions src/components/Editor/MarkdownContentEditor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,15 @@ export default {
extensions: this.extensions(),
onUpdate: ({ editor }) => {
const markdown = (createMarkdownSerializer(this.$editor.schema)).serialize(editor.state.doc)
this.$root.$emit('update:content', {
this.emit('update:content', {
json: editor.state.doc,
markdown,
})
},
onCreate: ({ editor }) => {
this.$emit('ready')
this.$parent.$emit('ready')
}

Check warning on line 166 in src/components/Editor/MarkdownContentEditor.vue

View workflow job for this annotation

GitHub Actions / eslint

Missing trailing comma
})
},
Expand All @@ -168,8 +172,24 @@ export default {
},
outlineToggled(visible) {
this.$emit('outline-toggled', visible)
this.$parent.$emit('outline-toggled', visible)
this.emit('outline-toggled', visible)
},
/**
* Wrapper to emit events on our own and the parent component
*
* The parent might be either the root component of src/editor.js or Viewer.vue which collectives currently uses
*
* Ideally this would be done in a generic way in the src/editor.js API abstraction, but it seems
* that there is no proper way to pass any received event along in vue, the only option I've found
* in https://github.com/vuejs/vue/issues/230 feels too hacky to me, so we just emit twice for now
*
* @param {string} event The event name
* @param {any} data The data to pass along
*/
emit(event, data) {
this.$emit(event, data)
this.$parent?.$emit(event, data)
},
},
}
Expand Down

0 comments on commit b8513d6

Please sign in to comment.