fix: remove incorrect role attrs from menu bar

All these roles are correctly set by NcAction* components when needed. Setting this roles in mixins and menu bar puts them on wrong elements. Signed-off-by: Grigorii K. Shartsev <[email protected]>
nextcloud · Jan 9, 2024 · 6bd3df5 · 6bd3df5
1 parent 2a8aef9
commit 6bd3df5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/src/components/Menu/ActionAttachmentUpload.vue b/src/components/Menu/ActionAttachmentUpload.vue
@@ -26,7 +26,6 @@
 		:title="actionEntry.label"
 		:aria-label="actionEntry.label"
 		:container="menuIDSelector"
-		role="menu"
 		aria-haspopup>
 		<template #icon>
 			<component :is="icon"

diff --git a/src/components/Menu/ActionList.vue b/src/components/Menu/ActionList.vue
@@ -23,7 +23,6 @@
 <template>
 	<NcActions :title="tooltip"
 		class="entry-list-action entry-action"
-		role="menu"
 		v-bind="state"
 		:container="menuIDSelector"
 		:aria-label="actionEntry.label"

diff --git a/src/components/Menu/ActionSingle.vue b/src/components/Menu/ActionSingle.vue
@@ -129,7 +129,6 @@ export default {
 			attrs: {
 				title,
 				type: attrs.active ? 'primary' : 'tertiary',
-				role: 'menuitem',
 				'data-text-action-entry': actionEntry.key,
 				...attrs,
 			},