Merge pull request #6211 from nextcloud/fix/upload_attachments

fix(attachments): Uploading of attachments from public shares
nextcloud · Aug 15, 2024 · 6637a3b · 6637a3b
2 parents 1ec5cf5 + 7a29b7b
commit 6637a3b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/lib/Controller/AttachmentController.php b/lib/Controller/AttachmentController.php
@@ -109,7 +109,7 @@ public function insertAttachmentFile(string $filePath): DataResponse {
 	#[NoAdminRequired]
 	#[PublicPage]
 	#[RequireDocumentSession]
-	public function uploadAttachment(string $shareToken = ''): DataResponse {
+	public function uploadAttachment(string $token = ''): DataResponse {
 		$documentId = $this->getSession()->getDocumentId();
 
 		try {
@@ -120,8 +120,8 @@ public function uploadAttachment(string $shareToken = ''): DataResponse {
 					throw new Exception('Could not read file');
 				}
 				$newFileName = $file['name'];
-				if ($shareToken) {
-					$uploadResult = $this->attachmentService->uploadAttachmentPublic($documentId, $newFileName, $newFileResource, $shareToken);
+				if ($token) {
+					$uploadResult = $this->attachmentService->uploadAttachmentPublic($documentId, $newFileName, $newFileResource, $token);
 				} else {
 					$userId = $this->getSession()->getUserId();
 					$uploadResult = $this->attachmentService->uploadAttachment($documentId, $newFileName, $newFileResource, $userId);

diff --git a/src/components/Editor/MediaHandler.vue b/src/components/Editor/MediaHandler.vue
@@ -110,8 +110,8 @@ export default {
 
 			return Promise.all(uploadPromises)
 				.catch(error => {
-					logger.error('Uploading multiple images failed', { error })
-					showError(error?.response?.data?.error || error.message)
+					logger.error('Uploading multiple attachments failed', { error })
+					showError(t('text', 'Uploading multiple attachments failed.'))
 				})
 				.then(() => {
 					this.state.isUploadingAttachments = false
@@ -128,8 +128,8 @@ export default {
 					)
 				})
 				.catch((error) => {
-					logger.error('Uploading image failed', { error })
-					showError(error?.response?.data?.error)
+					logger.error('Uploading attachment failed', { error })
+					showError(t('text', 'Uploading attachment failed.'))
 				})
 				.then(() => {
 					this.state.isUploadingAttachments = false
@@ -156,8 +156,8 @@ export default {
 					null, response.data?.dirname,
 				)
 			}).catch((error) => {
-				logger.error('Failed to insert image path', { error })
-				showError(error?.response?.data?.error || error.message)
+				logger.error('Failed to insert from Files', { error })
+				showError(t('text', 'Failed to insert from Files'))
 			}).then(() => {
 				this.state.isUploadingAttachments = false
 			})

diff --git a/src/services/SessionApi.js b/src/services/SessionApi.js
@@ -147,7 +147,7 @@ export class Connection {
 			+ '?documentId=' + encodeURIComponent(this.#document.id)
 			+ '&sessionId=' + encodeURIComponent(this.#session.id)
 			+ '&sessionToken=' + encodeURIComponent(this.#session.token)
-			+ '&shareToken=' + encodeURIComponent(this.#options.shareToken || '')
+			+ '&token=' + encodeURIComponent(this.#options.shareToken || '')
 		return this.#post(url, formData, {
 			headers: {
 				'Content-Type': 'multipart/form-data',