Merge pull request #5099 from nextcloud/backport/feature/hide-share-a…

…nd-close-buttons-on-direct-editing-stable27
nextcloud · Dec 7, 2023 · 5175811 · 5175811
2 parents 00698a7 + 7bb1d4a
commit 5175811
Show file tree

Hide file tree

Showing 14 changed files with 27 additions and 64 deletions.
diff --git a/cypress/e2e/directediting.spec.js b/cypress/e2e/directediting.spec.js
@@ -53,83 +53,41 @@ describe('direct editing', function() {
 		initUserAndFiles(user, 'test.md', 'empty.md', 'empty.txt')
 	})
 
-	it('Open an existing file, edit and close it', () => {
+	it('Open an existing file, edit it', () => {
 		createDirectEditingLink(user, 'empty.md')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token)
 			})
-		const closeRequestAlias = 'closeRequest'
-		cy.intercept({ method: 'POST', url: '**/session/close' }).as(closeRequestAlias)
-		cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' }).as('sync')
 		cy.getContent().type('# This is a headline')
 		cy.getContent().type('{enter}')
 		cy.getContent().type('Some text')
 		cy.getContent().type('{enter}')
-
-		// ensure we have received our own steps
-		cy.wait('@sync', { timeout: 7000 })
-		cy.wait('@sync', { timeout: 7000 })
-
-		cy.get('button.icon-close').click()
-		cy.wait(`@${closeRequestAlias}`).then(() => {
-			cy.getFileContent('empty.md').then((content) => {
-				expect(content).to.equal('# This is a headline\n\nSome text')
-			})
-		})
 	})
 
-	it('Create a file, edit and close it', () => {
+	it('Create a file, edit it', () => {
 		createDirectEditingLinkForNewFile(user, 'newfile.md')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token)
 			})
-		const closeRequestAlias = 'closeRequest'
-		cy.intercept({ method: 'POST', url: '**/session/close' }).as(closeRequestAlias)
-		cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' }).as('sync')
 
 		cy.getContent().type('# This is a headline')
 		cy.getContent().type('{enter}')
 		cy.getContent().type('Some text')
 		cy.getContent().type('{enter}')
-
-		// ensure we have received our own steps
-		cy.wait('@sync', { timeout: 7000 })
-		cy.wait('@sync', { timeout: 7000 })
-
-		cy.get('button.icon-close').click()
-		cy.wait(`@${closeRequestAlias}`).then(() => {
-			cy.getFileContent('newfile.md').then((content) => {
-				expect(content).to.equal('# This is a headline\n\nSome text')
-			})
-		})
 	})
 
-	it('Open an existing plain text file, edit and close it', () => {
+	it('Open an existing plain text file, edit it', () => {
 		createDirectEditingLink(user, 'empty.txt')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token)
 			})
-		const closeRequestAlias = 'closeRequest'
-		cy.intercept({ method: 'POST', url: '**/session/close' }).as(closeRequestAlias)
-		cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' }).as('sync')
 
 		cy.getContent().type('# This is a headline')
 		cy.getContent().type('{enter}')
 		cy.getContent().type('Some text')
 		cy.getContent().type('{enter}')
-
-		// ensure we have received our own steps
-		cy.wait('@sync', { timeout: 7000 })
-		cy.wait('@sync', { timeout: 7000 })
-
-		cy.get('button.icon-close').click()
-		cy.wait(`@${closeRequestAlias}`).then(() => {
-			cy.getFileContent('empty.txt').then((content) => {
-				expect(content).to.equal('# This is a headline\nSome text\n')
-			})
-		})
 	})
 })
diff --git a/js/editor.js b/js/editor.js
diff --git a/js/editor.js.map b/js/editor.js.map
diff --git a/js/text-editors.js b/js/text-editors.js
diff --git a/js/text-editors.js.map b/js/text-editors.js.map
diff --git a/js/text-files.js b/js/text-files.js
diff --git a/js/text-files.js.map b/js/text-files.js.map
diff --git a/js/text-public.js b/js/text-public.js
diff --git a/js/text-public.js.map b/js/text-public.js.map
diff --git a/js/text-text.js b/js/text-text.js
diff --git a/js/text-text.js.map b/js/text-text.js.map
diff --git a/js/text-viewer.js b/js/text-viewer.js
diff --git a/js/text-viewer.js.map b/js/text-viewer.js.map
diff --git a/src/views/DirectEditing.vue b/src/views/DirectEditing.vue
@@ -29,7 +29,7 @@
 			:mime="initial.mimetype"
 			:is-direct-editing="true"
 			@ready="loaded">
-			<template #header>
+			<template v-if="isMobile" #header>
 				<button class="icon-share" @click="share" />
 				<button class="icon-close" @click="close" />
 			</template>
@@ -103,6 +103,11 @@ export default {
 		initialSession() {
 			return JSON.parse(this.initial.session) || null
 		},
+		isMobile() {
+			return (window.DirectEditingMobileInterface || (window.webkit
+				&& window.webkit.messageHandlers
+				&& window.webkit.messageHandlers.DirectEditingMobileInterface))
+		},
 	},
 	beforeMount() {
 		callMobileMessage('loading')