fix(attachments): Show proper error message at upload error

Fixes: #6269 Signed-off-by: Jonas <[email protected]>
nextcloud · Aug 28, 2024 · 4cc321f · 4cc321f
1 parent 25e7cff
commit 4cc321f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/lib/Controller/AttachmentController.php b/lib/Controller/AttachmentController.php
@@ -23,6 +23,7 @@
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\RedirectResponse;
 use OCP\Files\IMimeTypeDetector;
+use OCP\Files\InvalidPathException;
 use OCP\IL10N;
 use OCP\IRequest;
 use OCP\Util;
@@ -133,7 +134,11 @@ public function uploadAttachment(string $token = ''): DataResponse {
 				}
 			}
 			return new DataResponse(['error' => 'No uploaded file'], Http::STATUS_BAD_REQUEST);
-		} catch (Exception $e) {
+		} catch (InvalidPathException $e) {
+			$this->logger->error('Upload error', ['exception' => $e]);
+			$error = $e->getMessage() ?: 'Upload error';
+			return new DataResponse(['error' => $error], Http::STATUS_BAD_REQUEST);
+		} catch (Exception) {
 			$this->logger->error('Upload error', ['exception' => $e]);
 			return new DataResponse(['error' => 'Upload error'], Http::STATUS_BAD_REQUEST);
 		}

diff --git a/lib/Service/AttachmentService.php b/lib/Service/AttachmentService.php
@@ -16,6 +16,7 @@
 use OCP\Constants;
 use OCP\Files\File;
 use OCP\Files\Folder;
+use OCP\Files\IFilenameValidator;
 use OCP\Files\IMimeTypeDetector;
 use OCP\Files\InvalidPathException;
 use OCP\Files\IRootFolder;
@@ -35,7 +36,8 @@ public function __construct(private IRootFolder $rootFolder,
 		private ShareManager $shareManager,
 		private IPreview $previewManager,
 		private IMimeTypeDetector $mimeTypeDetector,
-		private IURLGenerator $urlGenerator) {
+		private IURLGenerator $urlGenerator,
+		private IFilenameValidator $filenameValidator) {
 	}
 
 	/**
@@ -263,6 +265,7 @@ public function uploadAttachment(int $documentId, string $newFileName, $newFileR
 		}
 		$saveDir = $this->getAttachmentDirectoryForFile($textFile, true);
 		$fileName = self::getUniqueFileName($saveDir, $newFileName);
+		$this->filenameValidator->validateFilename($fileName);
 		$savedFile = $saveDir->newFile($fileName, $newFileResource);
 		return [
 			'name' => $fileName,
@@ -293,6 +296,7 @@ public function uploadAttachmentPublic(?int $documentId, string $newFileName, $n
 		$textFile = $this->getTextFilePublic($documentId, $shareToken);
 		$saveDir = $this->getAttachmentDirectoryForFile($textFile, true);
 		$fileName = self::getUniqueFileName($saveDir, $newFileName);
+		$this->filenameValidator->validateFilename($fileName);
 		$savedFile = $saveDir->newFile($fileName, $newFileResource);
 		return [
 			'name' => $fileName,

diff --git a/src/components/Editor/MediaHandler.vue b/src/components/Editor/MediaHandler.vue
@@ -129,7 +129,11 @@ export default {
 				})
 				.catch((error) => {
 					logger.error('Uploading attachment failed', { error })
-					showError(t('text', 'Uploading attachment failed.'))
+					if (error.response?.data.error) {
+						showError(t('text', 'Uploading attachment failed: {error}', { error: error.response.data.error }))
+					} else {
+						showError(t('text', 'Uploading attachment failed.'))
+					}
 				})
 				.then(() => {
 					this.state.isUploadingAttachments = false