Merge pull request #6315 from nextcloud/fix/mention_whitespace

fix(mention): No extra whitespace in markdown before/after mentions
nextcloud · Sep 5, 2024 · 19951d5 · 19951d5
2 parents 49e6aa9 + aeeaad9
commit 19951d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/extensions/Mention.js b/src/extensions/Mention.js
@@ -40,8 +40,6 @@ export default TipTapMention.extend({
 	},
 
 	toMarkdown(state, node) {
-		state.write(' ')
 		state.write(`@[${node.attrs.label}](mention://user/${encodeURIComponent(node.attrs.id)})`)
-		state.write(' ')
 	},
 })
diff --git a/src/tests/markdown.spec.js b/src/tests/markdown.spec.js
@@ -124,7 +124,8 @@ describe('Markdown though editor', () => {
 	})
 
 	test('mentions', () => {
-		expect(markdownThroughEditor('@[username](mention://user/id)')).toBe(' @[username](mention://user/id) ')
+		expect(markdownThroughEditor('@[username](mention://user/id)')).toBe('@[username](mention://user/id)')
+		expect(markdownThroughEditor('pretext @[username](mention://user/id) posttext')).toBe('pretext @[username](mention://user/id) posttext')
 	})
 
 	test('details', () => {
@@ -197,8 +198,9 @@ describe('Markdown serializer from html', () => {
 	})
 
 	test('mentions', () => {
-		expect(markdownThroughEditorHtml('<span class="mention" data-label="username" data-type="user" data-id="id">username</span>')).toBe(' @[username](mention://user/id) ')
-		expect(markdownThroughEditorHtml('<span class="mention" data-label="whitespace user" data-type="user" data-id="whitespace user">whitespace user</span>')).toBe(' @[whitespace user](mention://user/whitespace%20user) ')
+		expect(markdownThroughEditorHtml('<span class="mention" data-label="username" data-type="user" data-id="id">username</span>')).toBe('@[username](mention://user/id)')
+		expect(markdownThroughEditorHtml('<span class="mention" data-label="whitespace user" data-type="user" data-id="whitespace user">whitespace user</span>')).toBe('@[whitespace user](mention://user/whitespace%20user)')
+		expect(markdownThroughEditorHtml('pretext <span class="mention" data-label="username" data-type="user" data-id="id">username</span> posttext')).toBe('pretext @[username](mention://user/id) posttext')
 	})
 
 	test('details', () => {