📝 Note to self #1378
Merged
📝 Note to self #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemKeeper
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Noted some differences to web:
- In web it's allowed to change the name/description and avatar of the room, on iOS it's forbidden
- "Note to self" context menu item should not be available when inside the "Note to self" room
- Web allows to clear the messages
- Web allows to delete the room (we have "Leave conversation", which makes the room disappear because the only participant left, but guess that's not the intention). Web sends DELETE to
ocs/v2.php/apps/spreed/api/v4/room/...
|
Also in Web the Start call button is completely hidden, should we hide it as well instead of disabling? |
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
Signed-off-by: Ivan Sein <[email protected]>
SystemKeeper
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #300