Merge pull request #1546 from nextcloud/improve-speaker-button-inside…

…-menu Improve speaker button inside menu
nextcloud · Feb 21, 2024 · a3184b8 · a3184b8
2 parents 790db7d + 629c976
commit a3184b8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/NextcloudTalk/CallViewController.m b/NextcloudTalk/CallViewController.m
@@ -918,11 +918,12 @@ - (void)adjustMoreButtonMenu
     NCAudioController *audioController = [NCAudioController sharedInstance];
     if ([self.speakerButton isHidden] && [audioController isAudioRouteChangeable]) {
         // TODO: Adjust for AirPlay?
-        UIImage *speakerImage = [UIImage systemImageNamed:@"speaker.wave.3.fill"];
-        NSString *speakerActionTitle = NSLocalizedString(@"Speaker", nil);
+        UIImage *speakerImage = [UIImage systemImageNamed:@"speaker.slash.fill"];
+        NSString *speakerActionTitle = NSLocalizedString(@"Disable speaker", nil);
 
         if (![NCAudioController sharedInstance].isSpeakerActive) {
-            speakerImage = [UIImage systemImageNamed:@"speaker.slash.fill"];
+            speakerImage = [UIImage systemImageNamed:@"speaker.wave.3.fill"];
+            speakerActionTitle = NSLocalizedString(@"Enable speaker", nil);
         }
 
         UIAction *speakerAction = [UIAction actionWithTitle:speakerActionTitle image:speakerImage identifier:nil handler:^(UIAction *action) {

diff --git a/NextcloudTalk/en.lproj/Localizable.strings b/NextcloudTalk/en.lproj/Localizable.strings
@@ -646,6 +646,9 @@
 /* No comment provided by engineer. */
 "Disable blur" = "Disable blur";
 
+/* No comment provided by engineer. */
+"Disable speaker" = "Disable speaker";
+
 /* No comment provided by engineer. */
 "Disconnected" = "Disconnected";
 
@@ -814,6 +817,9 @@
 /* No comment provided by engineer. */
 "Enable screensharing" = "Enable screensharing";
 
+/* No comment provided by engineer. */
+"Enable speaker" = "Enable speaker";
+
 /* No comment provided by engineer. */
 "End call" = "End call";