Show localizable difference and remove UTF-8 BOM

Signed-off-by: Marcel Müller <[email protected]>
nextcloud · Oct 26, 2023 · 7ed04db · 7ed04db
1 parent afe5028
commit 7ed04db
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/localizable.yml b/.github/workflows/localizable.yml
@@ -34,6 +34,10 @@ jobs:
       run: |
         source ./generate-localizable-strings-file.sh
 
+    - name: Run git diff
+      run: |
+        git diff
+
     - name: Verify Changed files
       uses: tj-actions/verify-changed-files@v16
       id: verify-changed-files

diff --git a/NextcloudTalk/en.lproj/Localizable.strings b/NextcloudTalk/en.lproj/Localizable.strings
@@ -1,4 +1,4 @@
-/* No comment provided by engineer. */
+/* No comment provided by engineer. */
 "%@ added to this new group conversation" = "%@ added to this new group conversation";
 
 /* No comment provided by engineer. */

diff --git a/generate-localizable-strings-file.sh b/generate-localizable-strings-file.sh
@@ -5,7 +5,7 @@
 echo 'Generating Localizable.strings file...'
 cd NextcloudTalk
 genstrings -o en.lproj *.m *.swift ../ShareExtension/*.m ../NotificationServiceExtension/*.m ../ThirdParty/SlackTextViewController/Source/*.m
-iconv -f UTF-16LE -t UTF-8 en.lproj/Localizable.strings > en.lproj/Localizable-utf8.strings
+iconv -f UTF-16 -t UTF-8 en.lproj/Localizable.strings > en.lproj/Localizable-utf8.strings
 mv en.lproj/Localizable-utf8.strings en.lproj/Localizable.strings
 echo 'Localizable.strings file generated!'