Merge pull request #1372 from nextcloud/test-with-24

Test with 23

.github/workflows/uitests.yml

@@ -6,6 +6,7 @@ on:
       - '.github/workflows/**'
       - NextcloudTalk.xcodeproj/**
       - NextcloudTalk/**
+      - NextcloudTalkUITests/**
       - NotificationServiceExtension/**
       - ShareExtension/**
 
@@ -26,7 +27,8 @@ jobs:
 
     strategy:
       matrix:
-        test-branches: ['stable27', 'master']
+        # Test with stable23 as well to find regressions in older versions
+        test-branches: ['stable23', 'stable27', 'master']
 
     env:
       WORKSPACE: NextcloudTalk.xcworkspace
@@ -41,7 +43,14 @@ jobs:
       uses: actions/checkout@v3
       with:
         submodules: true
-
+
+    - uses: actions/cache@v3
+      with:
+        path: Pods
+        key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-pods-
+
     - name: Install docker
       run: |
         brew install docker

NextcloudTalkUITests/NextcloudTalkUITests.swift

@@ -200,8 +200,16 @@ final class NextcloudTalkUITests: XCTestCase {
         message.press(forDuration: 2.0)
 
         // Add a reaction to close the context menu
-        XCTAssert(app.staticTexts["👍"].waitForExistence(timeout: timeoutShort))
-        app.staticTexts["👍"].tap()
+        let reactionExists = app.staticTexts["👍"].waitForExistence(timeout: timeoutShort)
+
+        if reactionExists {
+            app.staticTexts["👍"].tap()
+        } else {
+            // In case we are testing against a nextcloud version that does not support reactions (<= NC 23)
+            // we simply tap the "Reply" button from the context menu
+            XCTAssert(app.buttons["Reply"].waitForExistence(timeout: timeoutShort))
+            app.buttons["Reply"].tap()
+        }
 
         // Go back to the main view controller
         let chatNavBar = app.navigationBars["NCChatView"]