Merge pull request #1384 from RomanPodymov/master #1936
IvansssAnnotations
11 warnings
|
SwiftLint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
SwiftLint:
NextcloudTalk/BaseChatViewController.swift#L2358
Todo Violation: TODOs should be resolved (There should be a better place...) (todo)
|
|
SwiftLint:
NextcloudTalk/BaseChatViewController.swift#L2750
Todo Violation: TODOs should be resolved (Take padding into account) (todo)
|
|
SwiftLint:
NextcloudTalk/RoomAvatarInfoTableViewController.swift#L80
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
|
|
SwiftLint:
NextcloudTalk/UIControlExtensions.swift#L28
Unused Closure Parameter Violation: Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
|
|
SwiftLint:
NextcloudTalk/DiagnosticsTableViewController.swift#L304
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
|
|
SwiftLint:
NextcloudTalk/DiagnosticsTableViewController.swift#L580
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 19 (cyclomatic_complexity)
|
|
SwiftLint:
NextcloudTalk/DiagnosticsTableViewController.swift#L517
Empty Count Violation: Prefer checking `isEmpty` over comparing `count` to zero (empty_count)
|
|
SwiftLint:
NextcloudTalk/ChatViewController.swift#L935
Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
|
|
SwiftLint:
NextcloudTalk/ChatViewController.swift#L1620
Identifier Name Violation: Variable name 'NCChatViewControllerReplyPrivatelyNotification' should be between 0 and 40 characters long (identifier_name)
|
|
SwiftLint:
NextcloudTalk/ChatViewController.swift#L1622
Identifier Name Violation: Variable name 'NCChatViewControllerTalkToUserNotification' should be between 0 and 40 characters long (identifier_name)
|