Notify Me Later About a Message

[rapterjet2004]

fixes #3221

issue-3221-draft-4.webm

• Functionality
• review

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

really great @rapterjet2004 👍 👍

there is something wrong with setting custom dates:

• e.g. when i set a custom reminder for today, it is actually set for tomorrow
• when i set i to some date next month, it was set to tomorrow or some random other day..

Screen_recording_20230830_104518.mp4

[rapterjet2004]

@mahibi
Should be fixed now. I forgot to include the selected week of the year when calculating the time in milliseconds. So when you clicked on Friday, September 29th, it would pick the Friday of the current week in August, instead of that week in September.

Also, apparently there was a weird time zone error. The Material Date Picker uses UTC, but doesn't convert it to
local GMT time. I had to offset it by TimeZone.getDefault().getOffset(localTimeInMillis)) when creating the datePicker, and to remove the offset when processing the selected time. Not sure why that wasn't included in the documentation.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	93	93
Errors	0	0

SpotBugs

Category	Base	New
Correctness	9	9
Dodgy code	127	127
Internationalization	5	5
Malicious code vulnerability	3	3
Performance	8	8
Security	2	2
Total	154	154

[mahibi]

@mahibi Should be fixed now. I forgot to include the selected week of the year when calculating the time in milliseconds. So when you clicked on Friday, September 29th, it would pick the Friday of the current week in August, instead of that week in September.

Also, apparently there was a weird time zone error. The Material Date Picker uses UTC, but doesn't convert it to local GMT time. I had to offset it by TimeZone.getDefault().getOffset(localTimeInMillis)) when creating the datePicker, and to remove the offset when processing the selected time. Not sure why that wasn't included in the documentation.

i confirm it's fixed.
rebased on master and enabled auto-merge..

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3256-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!