-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up fixes for the Waveform SeekBar #3234
Conversation
- Larger Bar gap - Centered time below play/pause button - Time is the same color as the play/pause button Signed-off-by: Julius Linus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look better on my high-res device 👍
0fce2b8
to
1af04d2
Compare
So feel free to merge @rapterjet2004 (or I can since the analysis check is failing (in general, everywhere)) |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3234-talk.apk |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Fixes this
Unfortunately, I wasn't able to fix the play time size. It's puzzling as on paper they should be equal
I believe that there is some underlying logic morphing the timestamp in
fun showReactions
located in thecom.nextcloud.talk.adapters.messages.Reaction
, but I didn't want to mess with it.I did some refactoring, so now the number of bars is calculated based off the width of the SeekBar itself. And by extension, the bar gap should also be calculated based off the width of the SeekBar, therefore no matter the size, it should always maintain a good ratio.
Before
follow-up-waveform-seekbar-fixes-before.webm
After
follow-up-waveform-seekbar-fixes-after.webm
🏁 Checklist
/backport to stable-xx.x