Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Call): introduce intermediary phase before joining call #13329

Merged
merged 10 commits into from
Nov 8, 2024
Merged

fix(Call): introduce intermediary phase before joining call #13329

merged 10 commits into from
Nov 8, 2024
+354 −106

Commits on Nov 8, 2024

  1. fix(ParticipantsStore): remove unnecessary event listeners and timeou… 

    …t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2e74e61 View commit details
    Browse the repository at this point in the history

  2. Fix(ParticipantsStore): separate joining states from each others (isI… 

    …nCall, connecting, connection failed)

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    609c1b8 View commit details
    Browse the repository at this point in the history

  3. feat(Call): Stop switching to CallView without a successful join. Int… 

    …roduce a failed join message dialog.

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    cc3675d View commit details
    Browse the repository at this point in the history

  4. fix(Call): stop all media related streams (simulating end call) 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    063755b View commit details
    Browse the repository at this point in the history

  5. fix: distinguish the 2 phases of joining the call: connect to the cal… 

    …l AND wait for participants list

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    37a9ef2 View commit details
    Browse the repository at this point in the history

  6. fix: move failed call dialog to root 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4511a20 View commit details
    Browse the repository at this point in the history

  7. fix: refactoring 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    073bf8d View commit details
    Browse the repository at this point in the history

  8. fix: add loading icon for leave call button 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e81854a View commit details
    Browse the repository at this point in the history

  9. fix: pass actual flags 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    afd1f58 View commit details
    Browse the repository at this point in the history

  10. fix: add tests 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    dba5c4b View commit details
    Browse the repository at this point in the history