Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request fullscreen for the whole page #13320

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 16, 2024

☑️ Resolves

  • Fix broken toast messages, removes need for reparenting Viewer, e.t.c
  • Instead of requesting a fullscreen for App, do it for the document.body (hide header and resize content to make it look the same)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Check recording appearance
  • Check toast messages everywhere
  • Check styles in talk sidebars for mounted elements
  • Follow-up: get rid of uiModeStore and mainSelector

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team- header should be hidden, and app-content stretched to the whole viewport, so apply custom styles

Signed-off-by: Maksim Sukharev [email protected]

src/App.vue Outdated Show resolved Hide resolved
src/FilesSidebarCallViewApp.vue Outdated Show resolved Hide resolved
src/FilesSidebarTabApp.vue Outdated Show resolved Hide resolved
src/composables/useViewer.js Show resolved Hide resolved
src/mainRecording.js Show resolved Hide resolved
store.dispatch('setMainContainerSelector', '#talk-sidebar')
store.dispatch('setMainContainerSelector', 'body')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this state now, if it is always body?

Copy link
Contributor Author

@Antreesy Antreesy Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to body, so it's not affecting components now. Want to move a clean-up of that store/state to the follow-up PR, since it's touching too many files
(NewMessage is broken now, if state is undefined)

@Antreesy
Copy link
Contributor Author

Tests:

Name Pic Pic2
nested Popovers and Modals image image
NcActions image image
Menus image image
Public chat 👍🏽
Files sidebar image image
Public share sidebar not available?
Password share sidebar image image
NewMessage tributes image
Toasts image
Recording image

@Antreesy Antreesy marked this pull request as ready for review September 18, 2024 19:49
- header should be hidden, and app-content stretched to the whole viewport, so apply custom styles

Signed-off-by: Maksim Sukharev <[email protected]>
- Viewer is always mounted next to the #content-vue, so it will be visible on body fullscreen-ed

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy merged commit 521c641 into main Sep 19, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/fullscreen-body branch September 19, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants