Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(CI): Test integration tests on GA #11144

Merged
merged 10 commits into from
Dec 7, 2023
Merged

[stable26] fix(CI): Test integration tests on GA #11144

merged 10 commits into from
Dec 7, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 7, 2023 •
edited
Loading

@nickvergessen nickvergessen added this to the 🧡 Next Patch (26) milestone Dec 7, 2023
@nickvergessen nickvergessen self-assigned this Dec 7, 2023
@nickvergessen nickvergessen force-pushed the migrate-integrationtests-to-drone branch 2 times, most recently from e3525d3 to 4fe3998 Compare December 7, 2023 07:00
@nickvergessen
fix(CI): Test integration tests on GA
fc010fa 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(CI): Remove old .drone.yml
ed86eea 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(CI): Kill stray child proccesses now that the php server is spawn…
7d4cd04 
…ing multiple childs

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Start 3 workers like on stable27
143ad99 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
chore(CI): Improve integration testing when custom skeleton was used
46c410b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
feat(CI): Make beginning of the tests quicker findable
836fb3d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(behat): Make comments finally visible
690cb0c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
tests(CI)!: Drop Drone CI
80893c3 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the migrate-integrationtests-to-drone branch from 4fe3998 to 80893c3 Compare December 7, 2023 07:56
SystemKeeper
SystemKeeper approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention it, this one misses the filtering on the PHP server, but guess for stable26 this is fine?!

https://github.com/nextcloud/spreed/blob/main/tests/integration/run.sh#L29

@nickvergessen nickvergessen merged commit a87dd22 into stable26 Dec 7, 2023
82 checks passed
@nickvergessen nickvergessen deleted the migrate-integrationtests-to-drone branch December 7, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
v16.0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper